Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PopupMenuController colors #1937

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Dec 4, 2023

Platforms Impacted

  • iOS
  • macOS

Description of changes

Fixing PopupMenuController colors. Fix is taken from #1936.

The tableview + cells should adopt the same color as the background of the drawer. They are still overridable if client wishes to change the colors through tokens.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

Colors before Colors after
image image
image image
image image
image image
image image
image image
image image
image image
image image
image image
image image
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@sophialee0416 sophialee0416 requested a review from a team as a code owner December 4, 2023 21:25
@sophialee0416 sophialee0416 enabled auto-merge (squash) December 4, 2023 21:26
@sophialee0416 sophialee0416 merged commit 5b5ca0a into microsoft:main Dec 5, 2023
6 checks passed
sophialee0416 added a commit to sophialee0416/fluentui-apple that referenced this pull request Dec 5, 2023
(cherry picked from commit 5b5ca0a)
@mischreiber mischreiber mentioned this pull request Mar 6, 2024
12 tasks
@sophialee0416 sophialee0416 deleted the sople/updateColors branch July 15, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants